[bids_import] Added validSamples to index.json + Self-descriptive renames #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Renamed function and variables
jeffersoncasimir
added
A-BIDS
driusan
pushed a commit
to aces/Loris
that referenced
this pull request
Jan 23, 2024
This resolves the data shift issue by adding the number of valid samples in the last chunk to the index.json, and using it for the calculations which previously assumed all chunks were filled. Closes #8992. Has a Loris-MRI counterpart: aces/Loris-MRI#1030 Loosely dependant on #8998 (file modifications in common and done at a later time).
|
@jeffersoncasimir who would best the best person to review this PR? |
|
@cmadjar I think all the developers who were given a test-25 clone VM (https://redmine.cbrain.mcgill.ca/issues/20684) should be able to test this with relatively little set-up time. The list, excluding myself: @laemtl, @nicolasbrossard, @CamilleBeau, @regisoc |
|
@laemtl @nicolasbrossard @CamilleBeau @regisoc could one of you review this PR? Thank you :-) |
laemtl
approved these changes
Feb 20, 2024
jeffersoncasimir
added a commit
to jeffersoncasimir/Loris
that referenced
this pull request
Feb 29, 2024
This resolves the data shift issue by adding the number of valid samples in the last chunk to the index.json, and using it for the calculations which previously assumed all chunks were filled. Closes aces#8992. Has a Loris-MRI counterpart: aces/Loris-MRI#1030 Loosely dependant on aces#8998 (file modifications in common and done at a later time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the data shift issue mentioned in aces/Loris#8892 by adding the number of valid samples in the last chunk to the index.json.
It has a Loris PR counterpart: aces/Loris#8999 to use this value and address the fact that some calculations were being made by multiplying the number of chunks by the number of values per chunk, assuming they were all full.